ci: configure git credentials for prerelease CDK clone#1371
Conversation
Package TarballHow to installgh release download pr-1371-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.14.2.tgz |
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
LGTM. Correct fix — moves token generation and git credential configuration before npm run bundle so the script's git clone of aws/agentcore-l3-cdk-constructs is authenticated. The insteadOf approach is a clean way to authenticate the clone without modifying scripts/bundle.mjs.
One small observation (non-blocking): .github/workflows/e2e-tests.yml and e2e-tests-full.yml both set owner: aws on the create-github-app-token step when they clone the same CDK repo, but this workflow omits it. If the App's default installation scope already covers the aws org this will work fine; otherwise you may need to add owner: aws to match those workflows. Since the linked failed run will tell you immediately, happy to defer to the next run.
31f3e22 to
321af1b
Compare
|
Claude Security Review: no high-confidence findings. (run) |
Description
Move GitHub App token generation before
npm run bundleand configure git credentials so the bundle script can clone the privateagentcore-l3-cdk-constructsrepo.The bundle script runs
git clone https://github.com/aws/agentcore-l3-cdk-constructs.gitwhich fails without credentials since the repo is private. This uses the samex-access-tokenpattern as the e2e test workflows.Failed run: https://github.com/aws/agentcore-cli/actions/runs/26293331790
Related Issue
N/A
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsWorkflow-only change — validated YAML syntax. Same
x-access-tokenpattern proven in e2e-tests.yml and e2e-tests-full.yml.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.