fix(e2e): add max_turns to SIMULATED_V1 dataset examples#1370
Closed
jariy17 wants to merge 1 commit into
Closed
Conversation
The dataset-lifecycle SIMULATED_V1 test was failing in CloudFormation with "'max_turns' must be an integer" because the inline example fixtures omitted the required field. Add max_turns to both examples so the AgentCore Dataset resource passes schema validation.
github-actions
Bot
added
the
agentcore-harness-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Contributor
Package TarballHow to installgh release download pr-1370-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.14.2.tgz |
agentcore-cli-automation
approved these changes
May 22, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
LGTM. The fix is consistent with the canonical src/assets/datasets/simulated-v1.jsonl sample, which already includes max_turns on every example. Adding it to the inline e2e fixtures aligns them with the SIMULATED_V1 schema enforced server-side.
I checked the other tests touching SIMULATED_V1 / simulated examples:
integ-tests/add-remove-dataset.test.tsalready assertsmax_turnsis present.e2e-tests/dataset-large-batch.test.tsuses PREDEFINED_V1 (turns), so it's unaffected.e2e-tests/dataset-eval-integration.test.tsalso uses PREDEFINED_V1.
No new product code, no new mocking patterns, no telemetry surface — pure test fixture fix. Nothing else to flag.
github-actions
Bot
removed
the
agentcore-harness-reviewing
Contributor
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
e2e: dataset lifecycle > deploys a SIMULATED_V1 schema type datasettest has been failing onmainbecause the inline example fixtures omit the requiredmax_turnsfield. CloudFormation rejects theAWS::BedrockAgentCore::Datasetresource with:This adds
max_turns: 5to both SIMULATED_V1 examples ine2e-tests/dataset-lifecycle.test.tsso the resource passes schema validation and the deploy completes.Note:
5is an arbitrary positive integer chosen to satisfy the schema — the failure surfaced no bound information, so any sane integer works.Test plan