feat: instrument telemetry for status command#1317
Open
Hweinstock wants to merge 3 commits into
Open
Conversation
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
github-actions
Bot
added
the
agentcore-harness-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Contributor
Package TarballHow to installgh release download pr-1317-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.14.2.tgz |
agentcore-cli-automation
suggested changes
May 20, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Nice refactor — telemetry coverage is thorough and the integ tests look good (real CLI invocations, no excessive mocking). One behavioral regression worth fixing before merging: removing the outer try/catch around loadStatusConfig() / handleRuntimeLookup / handleProjectStatus changes the exit code for thrown errors. See inline comment.
github-actions
Bot
removed
the
agentcore-harness-reviewing
Wrap status command execution paths with withCommandRunTelemetry: - Validation errors (invalid --type/--state) - Runtime lookup by ID (--runtime-id) - Default project status Schema changes: - Add runtime-endpoint, config-bundle, ab-test to FilterType enum Error typing: - Use ValidationError for invalid --type/--state input Tests: - Integration tests verifying telemetry emission for all paths
Hweinstock
force-pushed
the
feat/status-telemetry
branch
from
cfa51f8 to
ed0c3dd
Compare
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Hweinstock
commented
May 20, 2026
| render(<Text color="red">{result.error.message}</Text>); | ||
| } | ||
| return; | ||
| process.exit(1); |
Contributor
Author
There was a problem hiding this comment.
This is needed to maintain the current behavior since everything is wrapped in a result now the catch at the end would never get hit.
Ideally we bubble up the result and handle this at a higher-level, but that's a larger refactor that is OOS of this PR and is inconsistent with how the codebase currently does this.
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
After rebasing, the dataset enrichment code referenced context.deployedState outside the withCommandRunTelemetry callback where context was defined. Rather than hoisting context outside the callback (which would lose telemetry coverage for loadStatusConfig failures), include deployedState in the ProjectStatusResult so it flows through the Result type naturally.
Hweinstock
force-pushed
the
feat/status-telemetry
branch
from
30e9c3a to
37f3b48
Compare
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
avi-alpert
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instrument telemetry for all status command execution paths, following the patterns established by the invoke (#1227) and import (#1312) telemetry PRs.
Schema changes:
runtime-endpoint,config-bundle,ab-testtoFilterTypeenum (previously these valid filter values would silently drop telemetry)Related Issue
Closes #
Documentation PR
N/A — internal telemetry, no user-facing documentation changes.
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.