Fix/remove mpe length limit#94
Merged
Merged
Conversation
Remove CreateStack/CreateStackSet events and cloudformation:TagResource/ UpdateStack/UpdateStackSet permissions. CloudFormation stacks are not MAP-eligible resources, and tagging them causes CFN to propagate tags to child resources — triggering UPDATE_ROLLBACK_FAILED on unrelated stacks when the tagger role lacks Describe permissions on those children. DescribeStacks and ListStacks retained for peer-tagger detection.
The MPE ID input was restricted to exactly 10 characters across the Editor, Upgrade, and Delete flows. Real MPE IDs can be 1–44 characters (the deploy flow already allowed this). Align all flows to accept 1–44 chars with the same validation: uppercase A–Z and 0–9, at least one letter and one digit. Updated: regex validators, HTML maxlength attributes, error messages across all 7 i18n locales.
Prevents AlreadyExists error during upgrade. When upgrading from an older template that lacked this resource, the Lambda has already run and CloudWatch auto-created the log group. CFN then fails trying to create a resource that already exists. Same fix as PreflightLogGroup (v21.0.7). The Lambda already has logs:CreateLogGroup permission; CloudWatch handles log group creation automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of the change and the problem it solves.
Type of change
Testing
Checklist
cfn-lintpasses — checked by CI).github/scripts/resource_groups/for E2E coverageCHANGELOG.mdupdatedCI Notes