Skip to content

fix(test): Fix flaky VPC e2e tests for SG rule deletion #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sapphirew wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(test): Fix flaky VPC e2e tests for SG rule deletion #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/e2e/tests/test_vpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,9 @@ def test_disallow_default_security_group_rule(self, ec2_client, simple_vpc):
(ref, cr) = simple_vpc
resource_id = cr["status"]["vpcID"]

time.sleep(CREATE_WAIT_AFTER_SECONDS)
# Wait for the controller to finish reconciling (SG rule deletion
# happens inline during creation but the controller may be busy)
Comment on lines +252 to +253
Copy link
Copy Markdown
Contributor

@knottnt knottnt May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't think this is true anymore after you previous PR.

Suggested change
# Wait for the controller to finish reconciling (SG rule deletion
# happens inline during creation but the controller may be busy)
# Wait for the controller to finish reconciling (SG rule deletion
# happens in update path after initial creation)

assert k8s.wait_on_condition(ref, "ACK.ResourceSynced", "True", wait_periods=5)

# Check VPC exists in AWS
ec2_validator = EC2Validator(ec2_client)
Expand Down