Normalize system_architecture across platforms#2171
Open
petermm wants to merge 1 commit intoatomvm:release-0.7from
Open
Normalize system_architecture across platforms#2171petermm wants to merge 1 commit intoatomvm:release-0.7from
petermm wants to merge 1 commit intoatomvm:release-0.7from
Conversation
bettio
reviewed
Mar 12, 2026
petermm
force-pushed
the
fix-system_architecture
branch
5 times, most recently
from
8b53a90 to
a620188
Compare
petermm
changed the title
Contributor
Author
|
Ok, made it a make things correct PR, instead of following previous patterns. So reworked it completely - guaranteeing 3 parts/2 hyphens return, sanitised, stm32,rp2 etc Nitpicks can be had - should arm64 be normalised to aarch64, should elf/eabi be replaced by xyz. |
bettio
reviewed
Mar 13, 2026
petermm
force-pushed
the
fix-system_architecture
branch
2 times, most recently
from
4b16aba to
5dae26c
Compare
bettio
requested changes
Mar 20, 2026
Normalize system_architecture to arch-vendor-os form. Use compiler target strings where available and normalize them to exactly three components across generic Unix, Emscripten, ESP32, RP2, and STM32. Add a shared CMake helper for normalization, keep platform-specific vendor tags for RP2 and STM32, and extend system_architecture tests for generic Unix and ESP32. Signed-off-by: Peter M <petermm@gmail.com>
petermm
force-pushed
the
fix-system_architecture
branch
from
5dae26c to
452cf0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize
erlang:system_info(system_architecture)to a consistentarch-vendor-osformat across platforms.Before
Values were inconsistent and sometimes poorly ordered, for example:
Darwin-25.3.0-arm64Generic--After
Values now use normalized compiler-target-style strings with exactly
two hyphens, for example:
arm64-apple-darwin25.3.0xtensa-esp-esp_idfarm-rp2-nonearm-stm32-noneChanges
system_architectureFixes: #1371
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later