Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Fixes resources with variable name#29

Merged
winstliu merged 1 commit intoatom:masterfrom
petems:fix_resources_with_variable_names
Mar 12, 2016
Merged

Fixes resources with variable name#29
winstliu merged 1 commit intoatom:masterfrom
petems:fix_resources_with_variable_names

Conversation

@petems
Copy link
Copy Markdown
Contributor

@petems petems commented Mar 11, 2016

Lifted heavily from russCloak/SublimePuppet#20

Before:
screenshot 2016-03-11 15 38 11

After:
screenshot 2016-03-11 15 42 11

@winstliu
Copy link
Copy Markdown
Contributor

@petems Are you sure you referenced the correct issue? In addition, does #25 cover this already?

@petems petems force-pushed the fix_resources_with_variable_names branch from dc9bcf0 to 44d773e Compare March 11, 2016 15:30
@petems
Copy link
Copy Markdown
Contributor Author

petems commented Mar 11, 2016

@50Wliu Yep, it's still an issue, here's a screenshot of the current look (4 different highlights):
screenshot 2016-03-11 15 31 45

I'm fixing the space one in another PR

Comment thread grammars/puppet.cson
'1':
'name': 'storage.type.puppet'
'2':
'name': 'entity.name.section.puppet'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the match above captures

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

Before it would not be highlighted correclty
@petems petems force-pushed the fix_resources_with_variable_names branch from 44d773e to 52b9b43 Compare March 12, 2016 20:55
winstliu pushed a commit that referenced this pull request Mar 12, 2016
@winstliu winstliu merged commit 6879ea1 into atom:master Mar 12, 2016
@winstliu
Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants