Run black formatter - outdated version for Python 3.9#1624
Open
jerubball wants to merge 2 commits intoatlassian-api:masterfrom
Open
Run black formatter - outdated version for Python 3.9#1624jerubball wants to merge 2 commits intoatlassian-api:masterfrom
jerubball wants to merge 2 commits intoatlassian-api:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1624 +/- ##
==========================================
+ Coverage 42.09% 42.58% +0.49%
==========================================
Files 66 66
Lines 8693 8668 -25
Branches 1064 1058 -6
==========================================
+ Hits 3659 3691 +32
+ Misses 4897 4841 -56
+ Partials 137 136 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent merges had checks failing again.
I have run the black formatter, and also commented out unused import to have flake8 pass.
As pointed out in #1619, latest version of
black==26.3.1does not support Python 3.9.We have two options that I can think of.
One is to drop the Python 3.9 support, because it reached end of life on October 2025.
Other is to set the black version in
requirements-dev.txtfile toblack==25.11.0.This PR only runs formatter, and does not implement the solutions above.