[Jira]: Add alternative method to download all attachments zip file#1623
Draft
jerubball wants to merge 1 commit intoatlassian-api:masterfrom
Draft
[Jira]: Add alternative method to download all attachments zip file#1623jerubball wants to merge 1 commit intoatlassian-api:masterfrom
jerubball wants to merge 1 commit intoatlassian-api:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using existing method:
jira.download_issue_attachments()to get all attachments in zip file, the file is compressed from Jira server side first. The download may fail if total attachment size in a issue is too large. (Depends on Jira server, but typically > 1GB.)This PR adds new method
jira.get_all_attachment_contents()which downloads individual files, and use python'szipfilebuilt-in library to create zip file from client side.Docs file is updated accordingly, and passes black and mypy checks.