OUT-3174 | Use task title for breadcrumbs instead of task id#1199
OUT-3174 | Use task title for breadcrumbs instead of task id#1199arpandhakal wants to merge 1 commit intomainfrom
Conversation
…n dev tools - Breadcrumbs on task details page now show task title (truncated to 25 chars) instead of task id, on both internal-user and client views. - Switched useWindowWidth from window.outerWidth to window.innerWidth so the mobile layout (sidebar/description stacking) triggers correctly under dev-tools device emulation and inside narrow iframes, matching real-device behavior. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR makes two targeted changes: breadcrumbs on the task detail page now display the task Confidence Score: 5/5Safe to merge — both changes are minimal, correct, and well-tested by the provided test plan. No P0 or P1 issues found. The title field is guaranteed non-null by the Prisma schema so truncateText receives a valid string. The innerWidth switch is a well-known correctness improvement. No logic, security, or data integrity concerns. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Browser
participant TaskDetailPage as TaskDetailPage (server)
participant API as /api/tasks/:id/path
Browser->>TaskDetailPage: GET /detail/:task_id/:user_type
TaskDetailPage->>API: fetch task ancestor path
API-->>TaskDetailPage: AncestorTaskResponse[] (id, title, label, …)
TaskDetailPage->>TaskDetailPage: taskPath.map({ title, id })<br/>label = truncateText(title, 25)
TaskDetailPage-->>Browser: Renders HeaderBreadcrumbs<br/>with truncated titles as labels
Reviews (1): Last reviewed commit: "fix(OUT-3174): use task title for breadc..." | Re-trigger Greptile |
Summary
iu) and client (cu) views.useWindowWidthwas readingwindow.outerWidth, which doesn't shrink under Chrome dev-tools device emulation (and reports the parent window inside iframes). Switched towindow.innerWidthso the mobile sidebar/description stacking layout fires correctly in dev tools and matches real-device behavior.Linear: https://linear.app/assemblycom/issue/OUT-3174
Test plan
Test
An issue I found with the platform header:
🤖 Generated with Claude Code