OUT-3620: correct deposit retry date, status filter, and null validation#230
Draft
SandipBajracharya wants to merge 1 commit intoOUT-3617from
Draft
OUT-3620: correct deposit retry date, status filter, and null validation#230SandipBajracharya wants to merge 1 commit intoOUT-3617from
SandipBajracharya wants to merge 1 commit intoOUT-3617from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SandipBajracharya
changed the title
SandipBajracharya
force-pushed
the
OUT-3617
branch
from
8888863 to
98c76f4
Compare
…lidation Post the bank deposit on the PAID log date (not the retry date), filter the PAID sync log lookup to SUCCESS only, and validate expenseAccountRef the same way the expense path does. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
SandipBajracharya
force-pushed
the
OUT-3620
branch
from
9601eb3 to
95fd018
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createdAt— prevents dating the deposit on the retry day instead of the payment day.status = SUCCESSso we don't match an in-flight or failed PAID log whosequickbooksIdmay not exist in QBO yet.expenseAccountRefviaz.string().parse(...)in the deposit path, matching the expense path — surfaces a clear error on null instead of an opaque downstream Zod failure.Test plan
paidSyncLog.createdAtforTxnDategiven differingrecord.createdAtandpaidSyncLog.createdAt.status = SUCCESS(only FAILED/in-flight present).expenseAccountRefis null.Testing Criteria
https://www.loom.com/share/3ab767c5b9724c81bbe42c80dfba2ac2
🤖 Generated with Claude Code