OUT-3617: AB testing gate for bank deposit feature#229
Draft
SandipBajracharya wants to merge 10 commits intoOUT-3609from
Draft
OUT-3617: AB testing gate for bank deposit feature#229SandipBajracharya wants to merge 10 commits intoOUT-3609from
SandipBajracharya wants to merge 10 commits intoOUT-3609from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SandipBajracharya
force-pushed
the
OUT-3617
branch
from
9a353d1 to
e5dedee
Compare
When payments are received, optionally create QBO Bank Deposits that match the net amount deposited to the customer's bank (after Stripe fees), enabling automatic bank transaction matching. Payments are routed through Undeposited Funds, then a Bank Deposit moves the net amount to the bank account with the fee recorded as a negative line. This is behind a new opt-in bankDepositFeeFlag setting that requires absorbedFeeFlag to also be enabled. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…elector - Add GET endpoint for QBO bank accounts (/setting/bank-account) - Consolidate bankAccountRef write into settings POST endpoint (single API call) - Fix missing undepositedFundsAccountRef/bankAccountRef in token refresh and action - Fix deposit payload: add required TxnLineId to LinkedTxn - Fix Undeposited Funds lookup: query by AccountSubType instead of getOrCreate - Replace inline type with PaymentSucceededResponseType in handleBankDepositFlow - Add Sentry breadcrumbs and structured logging to bank deposit flow - Move deposit log after API call, use CustomLogger - Make PrivateNote optional in deposit schema - Add bankAccountRef to SettingRequestSchema and InvoiceSettingType - Add design doc for IntuitAPI token refresh (future ticket) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Wrap qb_settings + qb_portal_connections writes in db.transaction to prevent partial state (bankDepositFeeFlag=true with bankAccountRef=null) - Add null guard on paidSyncLog.amount before division in handleBankDepositFlow - Add invoiceNumber to failed DEPOSITED sync log for future resync support Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
SandipBajracharya
force-pushed
the
OUT-3609
branch
from
ab2bab2 to
dc21c89
Compare
SandipBajracharya
force-pushed
the
OUT-3617
branch
from
e5dedee to
8888863
Compare
SandipBajracharya
changed the title
arpandhakal
reviewed
Apr 20, 2026
Collaborator
arpandhakal
left a comment
arpandhakal
left a comment
There was a problem hiding this comment.
The migrations is being rewritten and not updated. I see the old migration file deleted and new one is introduced. Are these already pushed into preview, production databases? If so, I think that will cause a problem. Flagging this early.
Collaborator
Author
No we have not pushed those migration to production yet. However, we have ran this in supabase dev. It makes sense to update the migration file in first PR i.e on OUT-3064. Will update this and let you know |
Undeposited Funds is a QBO system account that always exists and cannot be deleted. Caching its ID in qb_portal_connections was unnecessary. - Add getUndepositedFundsAccountId() on IntuitAPI (live lookup by subtype) - Call it directly in invoice.service.ts instead of checkAndUpdateAccountStatus - Remove undepositedFundsAccountRef from schema, type, and all plumbing - Remove UndepositedFunds from AccountTypeObj, updateAccountMapping, restoreAccountRef - Reuse single IntuitAPI instance in webhookInvoicePaid - Update migration: drop undeposited_funds_account_ref column addition Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…s UI - Add bank account dropdown in InvoiceDetail below bankDepositFeeFlag checkbox - Fetch QBO bank accounts via SWR (GET /api/quickbooks/setting/bank-account) - Include bankAccountRef in settingState for single-request save - Add click-outside-to-close, loading state, and amber warning when unselected - Pass bankAccounts, isBankAccountsLoading, selectBankAccount props via SettingAccordion Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…t bank account Block the Confirm/Update button when bankDepositFeeFlag is on but no bank account is selected. Without a bank account, the webhook deposit flow throws on every payment.succeeded event. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
SandipBajracharya
force-pushed
the
OUT-3609
branch
from
dc21c89 to
18f49d0
Compare
- Add AB_FEATURE_TESTING_PORTALS env var to config (empty = all portals) - Create isPortalInBankDepositABTest utility for portal eligibility check - Gate bank deposit flow in invoice.service and webhook.service - Gate settings UI: return bankDepositEnabled from GET, hide checkbox/dropdown - Remove EventType.DEPOSITED — use SUCCEEDED for both legacy and deposit flows - Fix cascade bug: only reset bankDepositFeeFlag when feature is visible - Increase payment.succeeded sleep to 25s Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Strip bankDepositFeeFlag/bankAccountRef from payload for non-AB portals (prevents garbage state if portal is later added to AB list) - Reject bankDepositFeeFlag:true without bankAccountRef on the backend - Fix res.Deposit.Id optional chaining inconsistency in payment.service.ts Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
SandipBajracharya
force-pushed
the
OUT-3617
branch
from
8888863 to
98c76f4
Compare
SandipBajracharya
force-pushed
the
OUT-3609
branch
from
18f49d0 to
c191126
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AB_FEATURE_TESTING_PORTALSenv var for incremental rollout of bank deposit featureChanges
src/config/index.ts— parseAB_FEATURE_TESTING_PORTALScomma-separated listsrc/utils/abTesting.ts—isPortalInBankDepositABTest(portalId)utilitysrc/app/api/quickbooks/invoice/invoice.service.ts— AB check onuseBankDepositFlowsrc/app/api/quickbooks/webhook/webhook.service.ts— AB check onuseBankDepositFlowsrc/app/api/quickbooks/setting/setting.controller.ts— returnbankDepositEnabledin GETsrc/hook/useSettings.ts— conditional bank account fetch based onbankDepositEnabledsrc/components/— hide deposit checkbox + dropdown when portal not in AB testEventType.DEPOSITED— useSUCCEEDEDfor both flows (flag decides behavior)bankDepositFeeFlagwhen feature is visibleTest plan
AB_FEATURE_TESTING_PORTALS=<portal-id>in.env🤖 Generated with Claude Code