Skip to content

fix: nushell completions --ignore-errors deprecation#2157

Merged
Stratus3D merged 2 commits intoasdf-vm:masterfrom
rbuchberger:master
Apr 3, 2026
Merged

fix: nushell completions --ignore-errors deprecation#2157
Stratus3D merged 2 commits intoasdf-vm:masterfrom
rbuchberger:master

Conversation

@rbuchberger
Copy link
Copy Markdown
Contributor

@rbuchberger rbuchberger commented Jul 28, 2025

Summary

Update nushell completion code to use the new flag.

Edit: Warning! Will break completions entirely for anyone on earlier versions that 0.106.0. Maybe don't merge this.

Fixes: #2156

Other Information

Thanks for the great tool, I've been using it to earn a living for years.

@rbuchberger rbuchberger requested a review from a team as a code owner July 28, 2025 09:10
@rbuchberger
Copy link
Copy Markdown
Contributor Author

Wait, I've just realized the fix might need to be a little more complicated. It looks like nushell introduced the new flag and deprecated the old one in the same release. Merging this PR would break completions for anyone on earlier versions. I'm not sure how you want to handle that?

@hyperupcall
Copy link
Copy Markdown
Contributor

hyperupcall commented Mar 15, 2026

@rbuchberger Before, fixing the issue did mean breaking completions for people on older versions: #1681. The scripts/install_dependencies.bash was also modified to reflect the new, expected version.

I think it would be difficult to justify the work for a fix that doesn't break compatability, especially since Nushell is a pretty niche and fast-moving project.

@rbuchberger
Copy link
Copy Markdown
Contributor Author

Yeah, that sounds pretty reasonable to me. I don't think too many people are hanging out on old versions of nushell and unable to update. When I first made this issue 0.106.0 was brand new, but now they're several releases past that.

Copy link
Copy Markdown
Member

@Stratus3D Stratus3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rbuchberger ! I agree with @hyperupcall so I'm going to merge this without any other changes. However, it looks like the nushell instructions in our documentation also need to be updated to the new flag. Would you want to contribute another PR that?

@Stratus3D Stratus3D merged commit a813610 into asdf-vm:master Apr 3, 2026
7 checks passed
@Stratus3D Stratus3D mentioned this pull request Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Nushell's get --ignore-errors flag is deprecated.

3 participants