fix: nushell completions --ignore-errors deprecation#2157
fix: nushell completions --ignore-errors deprecation#2157Stratus3D merged 2 commits intoasdf-vm:masterfrom
Conversation
|
Wait, I've just realized the fix might need to be a little more complicated. It looks like nushell introduced the new flag and deprecated the old one in the same release. Merging this PR would break completions for anyone on earlier versions. I'm not sure how you want to handle that? |
|
@rbuchberger Before, fixing the issue did mean breaking completions for people on older versions: #1681. The I think it would be difficult to justify the work for a fix that doesn't break compatability, especially since Nushell is a pretty niche and fast-moving project. |
|
Yeah, that sounds pretty reasonable to me. I don't think too many people are hanging out on old versions of nushell and unable to update. When I first made this issue 0.106.0 was brand new, but now they're several releases past that. |
Stratus3D
left a comment
There was a problem hiding this comment.
Thanks for the PR @rbuchberger ! I agree with @hyperupcall so I'm going to merge this without any other changes. However, it looks like the nushell instructions in our documentation also need to be updated to the new flag. Would you want to contribute another PR that?
Summary
Update nushell completion code to use the new flag.
Edit: Warning! Will break completions entirely for anyone on earlier versions that 0.106.0. Maybe don't merge this.
Fixes: #2156
Other Information
Thanks for the great tool, I've been using it to earn a living for years.