Skip to content

Vhost settings#408

Merged
UserNotFound merged 12 commits intomasterfrom
vhost-settings
Apr 30, 2026
Merged

Vhost settings#408
UserNotFound merged 12 commits intomasterfrom
vhost-settings

Conversation

@UserNotFound
Copy link
Copy Markdown
Member

@UserNotFound UserNotFound commented Jan 21, 2026

The options should be self explanatory in the help. EG pass --idle-timeout 123 to set the IDLE_TIMEOUT for the Vhost. Less obvious behavior we'll need to add to the docs is how to unset and revert back to the platform default if you don't want to provide a value anymore: this can be accomplished with --idle-timeout="" or --idle-timeout default

Thor boolean option like --force-ssl and --no-force-ssl seem to provide no way to to revert, though I suppose we could add custom options like --default-idle-timeout and pass the value as a blank string to unset it in our API?

A modicum of integration tests will be added here: https://github.com/aptible/aptible-integration/pull/565

I recently updated the supported settings to match the UI and terraform's supported settings:

@UserNotFound
Copy link
Copy Markdown
Member Author

settings[key.to_s.upcase] = value.to_s
end

# This one we pass through to nginx for whatever rason, so
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'rason'

also this seems like maybe something we should handle in the sweetness level? i.e. make sure we're only passing 'on' or 'off' based on reasonable values? (What if someone does direct api calls?)

not something you need to fix here, just noting

aguilinger
aguilinger previously approved these changes Jan 22, 2026
@UserNotFound UserNotFound marked this pull request as ready for review April 21, 2026 18:59
@UserNotFound UserNotFound requested a review from aguilinger April 21, 2026 18:59
@promptless
Copy link
Copy Markdown

promptless Bot commented Apr 21, 2026

Promptless prepared a documentation update related to this change.

Triggered by aptible/aptible-cli#408

Documents new CLI options for managing endpoint settings including idle timeout, force SSL, SSL protocols, maintenance page URL, and other platform-specific options across HTTPS, TLS, gRPC, and TCP endpoint types. Updated 9 CLI reference pages to cover the new --idle-timeout, --force-ssl, --ssl-protocols-override, and other endpoint configuration options.

Review: Document CLI endpoint settings options

@UserNotFound UserNotFound merged commit 42ea790 into master Apr 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants