Skip to content

test: bound serve_in_thread teardown to prevent CI hangs #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 1 commit into from
May 12, 2026
+7 −2
Merged

test: bound serve_in_thread teardown to prevent CI hangs #1892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tests/unit/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,12 +541,17 @@ def run(self, sockets: list[socket] | None = None) -> None:

def serve_in_thread(server: TestServer) -> Iterator[TestServer]:
"""Run a server in a background thread and yield it."""
thread = threading.Thread(target=server.run)
thread = threading.Thread(target=server.run, daemon=True)
thread.start()
try:
while not server.started:
time.sleep(1e-3)
yield server
finally:
server.should_exit = True
thread.join()
thread.join(timeout=10)
if thread.is_alive():
# Uvicorn occasionally ignores should_exit; force_exit aborts the
# asyncio loop so teardown cannot hang the suite indefinitely.
server.force_exit = True
thread.join(timeout=5)
Loading