fix: Re-use pre-existing browser context in PlaywrightBrowserController#1778
Merged
fix: Re-use pre-existing browser context in PlaywrightBrowserController#1778
PlaywrightBrowserController#1778Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1778 +/- ##
==========================================
- Coverage 92.25% 92.20% -0.05%
==========================================
Files 156 156
Lines 10654 10654
==========================================
- Hits 9829 9824 -5
- Misses 825 830 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0a20346 to
2ce9364
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PlaywrightBrowserControllercan receive a browser with already active contexts. If that is the case, use the first active context directly in thePlaywrightBrowserControllerinstead of creating a new contextIssues
Testing
Checklist