[SPARK-56867][SQL] Respect spark.jars.ivySettings when downloading Hive metastore jars#55881
Open
sarutak wants to merge 1 commit into
Open
[SPARK-56867][SQL] Respect spark.jars.ivySettings when downloading Hive metastore jars#55881sarutak wants to merge 1 commit into
spark.jars.ivySettings when downloading Hive metastore jars#55881sarutak wants to merge 1 commit into
Conversation
Member
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Do you think we can have a test coverage for this to prevent a future regression, @sarutak ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR modifies
IsolatedClientLoader.downloadVersionto respect thespark.jars.ivySettingsconfiguration when resolving Hive metastore jars viaspark.sql.hive.metastore.jars=maven.Previously,
downloadVersionalways calledMavenUtils.buildIvySettingsdirectly, ignoring any custom Ivy settings file. With this change, ifspark.jars.ivySettingsis set,MavenUtils.loadIvySettingsis used instead, consistent with howDependencyUtils.resolveMavenDependencieshandles--packages.Why are the changes needed?
When
spark.sql.hive.metastore.jars=mavenis configured, Spark downloads Hive metastore jars using Apache Ivy. However, unlike--packages/spark.jars.packages, this code path did not honorspark.jars.ivySettings. This made it impossible to download Hive metastore jars from authenticated private repositories, since credentials can only be configured through an Ivy settings file.Does this PR introduce any user-facing change?
Yes. Users who set
spark.jars.ivySettingscan now have that configuration apply to Hive metastore jar resolution as well. Previously, the Ivy settings file was only used forspark.jars.packages.How was this patch tested?
Confirmed it works with a private repository which requires authentication.
Was this patch authored or co-authored using generative AI tooling?
Kiro CLI / Opus 4.7