[ISSUE:#1131] ctx param not work forconsumer.pullFrom method#1132
Open
zl03jsj wants to merge 2 commits intoapache:masterfrom
Open
[ISSUE:#1131] ctx param not work forconsumer.pullFrom method#1132zl03jsj wants to merge 2 commits intoapache:masterfrom
ctx param not work forconsumer.pullFrom method#1132zl03jsj wants to merge 2 commits intoapache:masterfrom
Conversation
zl03jsj
changed the title
ctx param is inefficient in pullFrom methodctx param not work in pullFrom method
zl03jsj
changed the title
ctx param not work in pullFrom methodctx param not work in consumer.pullFrom method
zl03jsj
changed the title
ctx param not work in consumer.pullFrom methodctx param not work in consumer.pullFrom method
zl03jsj
changed the title
ctx param not work in consumer.pullFrom methodctx param not work in consumer.pullFrom method
zl03jsj
changed the title
ctx param not work in consumer.pullFrom methodctx param not work forconsumer.pullFrom method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix: #1131
ctxparam ofconsumer.PullFromnot work, cause it was not used totally.(context.Background()is actually used.)rocketmq-client-go/consumer/consumer.go
Line 896 in f4875c1
rocketmq-client-go/internal/remote/future.go
Lines 63 to 65 in f4875c1
Brief changelog
make
ctxworking, and returns the explicit error.fix issue: #1131 (comment)