RATIS-2440. Let ratis-bom inherit from Apache parent#1381
Open
adoroszlai wants to merge 3 commits intoapache:masterfrom
Open
RATIS-2440. Let ratis-bom inherit from Apache parent#1381adoroszlai wants to merge 3 commits intoapache:masterfrom
adoroszlai wants to merge 3 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ratis-bommodule does not inherit fromratismain (root) POM to avoid leaking dependencies. However, it could inherit frommaven-apache-parent, which is also the parent ofratismain.This lets
ratis-bominherit, among others:apache-releaseprofiledistMgmtSnapshots*propertiesproject.build.outputTimestamp, to fix[ERROR] Reproducible Build not activated by project.build.outputTimestamp property...Also remove some of these items from root POM, which inherits them from:
https://github.com/apache/maven-apache-parent/blob/apache-35/pom.xml#L90-L92
https://github.com/apache/maven-apache-parent/blob/apache-35/pom.xml#L94-L95
https://github.com/apache/maven-apache-parent/blob/apache-35/pom.xml#L106
https://issues.apache.org/jira/browse/RATIS-2440
How was this patch tested?
CI:
https://github.com/adoroszlai/ratis/actions/runs/23310397439