Skip to content

[feat][ml] Support Bookkeeper Batch Read API#25280

Open
dao-jun wants to merge 10 commits intoapache:masterfrom
dao-jun:dev/support_bk_batch_read
Open

[feat][ml] Support Bookkeeper Batch Read API#25280
dao-jun wants to merge 10 commits intoapache:masterfrom
dao-jun:dev/support_bk_batch_read

Conversation

@dao-jun
Copy link
Copy Markdown
Member

@dao-jun dao-jun commented Mar 4, 2026

Motivation

In BP-62, Bookkeeper starting to support batch read API,
the PR is to support Bookkeeper batch reading on the Pulsar side.

Modifications

  1. Support Bookkeeper batch read API
  2. Introduce a new flag bookkeeperEnableBatchRead to control enable BK batch read or not, the default value is false.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@dao-jun dao-jun self-assigned this Mar 4, 2026
@dao-jun dao-jun added type/feature The PR added a new feature or issue requested a new feature ready-to-test area/ML labels Mar 4, 2026
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Mar 4, 2026
@apache apache deleted a comment from github-actions bot Mar 4, 2026
@merlimat merlimat requested a review from hangc0276 March 4, 2026 22:04
@codelipenghui codelipenghui added this to the 4.2.0 milestone Mar 5, 2026
Copy link
Copy Markdown
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EntryCacheDisabled.java should also adopt the new method?

And from the test perspective, this PR has 0 test coverage for the core batch read logic.

@dao-jun dao-jun marked this pull request as draft April 4, 2026 07:41
@dao-jun dao-jun marked this pull request as ready for review April 4, 2026 08:12
@dao-jun dao-jun closed this Apr 4, 2026
@dao-jun dao-jun reopened this Apr 4, 2026
@dao-jun dao-jun requested review from codelipenghui and coderzc April 5, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ML doc-not-needed Your PR changes do not impact docs ready-to-test type/feature The PR added a new feature or issue requested a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants