test: retry temporary port bind in RemotingSpec lazy-connect test#3015
Open
He-Pin wants to merge 1 commit into
Open
test: retry temporary port bind in RemotingSpec lazy-connect test#3015He-Pin wants to merge 1 commit into
He-Pin wants to merge 1 commit into
Conversation
Motivation: RemotingSpec "allow other system to connect even if it's not there at first" intermittently fails at ActorSystem startup with "Address already in use" (issue #1679). The test allocates a port via temporaryServerAddress() and then binds a new ActorSystem to it; the port can be claimed by another process between allocation and bind. Modification: Reuse the existing selectionAndBind helper (already used by the sibling "be able to connect to system even if it's not there at first" test), which retries on a fresh port when the bind fails with "Failed to bind". Result: The lazy-connect test no longer races temporary port allocation; it still passes locally. References: Fixes #1679
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
RemotingSpec"allow other system to connect even if it's not there at first" intermittently fails atActorSystemstartup with Address already in use (#1679).The test allocates a port via
temporaryServerAddress()and then binds a newActorSystemto it; the port can be claimed by another process between allocation and bind.Modification
Reuse the existing
selectionAndBindhelper — already used by the sibling "be able to connect to system even if it's not there at first" test — which retries on a fresh port when the bind fails withFailed to bind.Result
The lazy-connect test no longer races temporary port allocation; it still passes locally.
Tests
remote/testOnly org.apache.pekko.remote.classic.RemotingSpec -- -z "allow other system to connect even if"— passes.scalafmtrun on the changed file. Test-only change.References
Fixes #1679