GH-3549: Leverage JDK11 readNBytes#3550
Closed
Fokko wants to merge 3 commits intoapache:masterfrom
Closed
Conversation
Introduced in JDK11 and is more efficient. Closes apache#3549
| LOG.debug("read all {} bytes", byteCount); | ||
| byte[] buf = new byte[byteCount]; | ||
| new DataInputStream(in).readFully(buf); | ||
| byte[] buf = in.readNBytes(byteCount); |
Contributor
There was a problem hiding this comment.
hadn't noticed this before. Doesn't look like anything in the JDK has actually subclassed it ... that is there's no AFAIK there's no faster native code version. That's probably because java.nio is the way to go there
Contributor
Author
There was a problem hiding this comment.
I think it is nice to avoid the wrapper DataInputStream here. The biggest win here is in writeAllTo where we don't allocate all the bytes directly into memory, but respecting byteCount.
Contributor
Author
|
There seems to be an issue with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced in JDK11 and is more efficient.
Closes #3549
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?