HDDS-14862. Log volume failures and database errors as errors#9950
Draft
ptlrs wants to merge 1 commit intoapache:masterfrom
Draft
HDDS-14862. Log volume failures and database errors as errors#9950ptlrs wants to merge 1 commit intoapache:masterfrom
ptlrs wants to merge 1 commit intoapache:masterfrom
Conversation
adoroszlai
reviewed
Mar 19, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @ptlrs for working on this.
| dbLoaded.set(false); | ||
| dbLoadFailure.set(false); | ||
| LOG.info("SchemaV3 db is stopped at {} for volume {}", containerDBPath, | ||
| LOG.warn("SchemaV3 db is stopped at {} for volume {}", containerDBPath, |
Contributor
There was a problem hiding this comment.
closeDbStore() is executed in normal shutdown, too, so this shouldn't be a warning. For failure case, warning is logged in callers of failVolume.
| volumeHealthMetrics.decrementHealthyVolumes(); | ||
| volumeHealthMetrics.incrementFailedVolumes(); | ||
| LOG.info("Moving Volume : {} to failed Volumes", volumeRoot); | ||
| LOG.error("Moving Volume : {} to failed Volumes", volumeRoot); |
Contributor
There was a problem hiding this comment.
This is not an error. Callers of failVolume log at higher level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Volume failure is currently logged at INFO level. It should be marked as an ERROR as a volume failing is an actual problem in the system and also searching for ERRORs in the log files should flag this.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14862
How was this patch tested?
CI: https://github.com/ptlrs/ozone/actions/runs/23277693312