ORC-2134: Remove microsoft/setup-msbuild from GitHub Actions jobs#2584
Closed
dongjoon-hyun wants to merge 1 commit intoapache:mainfrom
Closed
ORC-2134: Remove microsoft/setup-msbuild from GitHub Actions jobs#2584dongjoon-hyun wants to merge 1 commit intoapache:mainfrom
microsoft/setup-msbuild from GitHub Actions jobs#2584dongjoon-hyun wants to merge 1 commit intoapache:mainfrom
Conversation
dongjoon-hyun
added a commit
that referenced
this pull request
Mar 21, 2026
### What changes were proposed in this pull request? Remove `microsoft/setup-msbuild` from GitHub Actions jobs. ### Why are the changes needed? Currently, the CI is broken because `microsoft/setup-msbuild` is no longer allowed by ASF Infra patterns. - https://github.com/apache/orc/actions/runs/23372953082 > microsoft/setup-msbuildv1.1 is not allowed in apache/orc because all actions must be from a repository owned by your enterprise, created by GitHub, or match one of the patterns: ... Technically, the `windows-2025` runner already includes MSBuild in PATH, so the `microsoft/setup-msbuildv1.1` step is unnecessary. ### How was this patch tested? Passed the existing GitHub Actions. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (claude-opus-4-6) Closes #2584 from dongjoon-hyun/ORC-2134. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit b2dc0f8) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
|
Merged to main/2.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove
microsoft/setup-msbuildfrom GitHub Actions jobs.Why are the changes needed?
Currently, the CI is broken because
microsoft/setup-msbuildis no longer allowed by ASF Infra patterns.Technically, the
windows-2025runner already includes MSBuild in PATH, so themicrosoft/setup-msbuild@v1.1step is unnecessary.How was this patch tested?
Passed the existing GitHub Actions.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-opus-4-6)