net/nat: g_nat_lock can be used recursively

[masc2008]

Note: Please adhere to Contributing Guidelines.

Summary

case: when rndis receive a packet and this packet is going to be forwarded.

1. first lock happen when ipv4_dev_forward call ipv4_nat_outbound;
2. next lock is: ipv4_nat_outbound_entry_find --> nat_port_select --> tcp_selectport --> nat_port_inuse

Impact

fix assert when NET_NAT is enabled, and packet forwards from one net device to another.

Testing

without this code, it has below assert:

[acassis]

@lupyuen @simbit18 seems like the CI tests are not running, this modification only triggered the jobs that normally are triggered for no invasive tests like when modifying CONTRIBUTIONS.md file. What is happening?

[lupyuen]

All CI Builds have been failing since 18 hours ago.

@simbit18 Would you know how to check the GitHub Actions allowed by ASF Infra Team? Wonder if they blocked something due to yesterday's Trivy Security Incident.

https://github.com/apache/nuttx/actions/runs/23389990049

The action docker/login-action@v4 is not allowed in apache/nuttx because all actions must be from a repository owned by your enterprise, created by GitHub, or match one of the patterns: 1Password/load-secrets-action@13f58ee, 1Password/load-secrets-action@8d0d610, 1Password/load-secrets-action@dafbe7c, AdoptOpenJDK/install-jdk@, BobAnkh/auto-generate-changelog@, DavidAnson/markdownlint-cli2-action@07035fd, DavidAnson/markdownlint-cli2-action@30a0e04, EnricoMi/publish-unit-test-result-action@*, JamesIves/github-pages-deploy-action@4a3abc7, JamesIves/github-pages-deploy-action@d92aa23, Jimver/cuda-toolkit@6008063, Jimver/cuda-toolkit@b6fc3a9, JustinBeckwith/linkinator-action@af984b9f30f63e796...

Update: Found the allowed GitHub Actions. It's updated recently, lemme see what they blocked...

• https://github.com/apache/infrastructure-actions/blob/main/actions.yml
• Which generates: https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml

Hmmm why did ASF Infra Team insist on docker/login-action@v3.7.0? Lemme submit a patch to roll back.

docker/login-action:
  c94ce9fb468520275223c153574b00df6fe4bcc9:
    tag: v3.7.0

[lupyuen]

This patch should fix our CI Builds:

• CI: Revert GitHub Actions for Docker #18574
• CI: Revert GitHub Actions for Docker, by hash #18575
• CI: Revert GitHub Actions for Docker nuttx-apps#3430

Yep the ASF Policy Change is due to the Trivy Security Incident. Yesterday somehow I failed to understand the meaning of the exact words when I read this broadcast email (maybe actions should have been stated explicitly as GitHub Actions): https://news.apache.org/foundation/entry/initial-report-on-trivy-security-incident

ASF Infra and ASF Security agreed to disable all previously allowed “verified creator” actions while the incident is being investigated

This may cause build failures, and require projects request newly-failed actions be added via the Infra GHA approval process: github.com/apache/infrastructure-actions?tab=readme-ov-file#adding-a-new-version-to-the-allow-list

[lupyuen]

Oops I need to pin to a Specific Hash, not just the Specific Version. Lemme resubmit the patch...

• CI: Revert GitHub Actions for Docker, by hash #18575
• CI: Revert GitHub Actions for Docker nuttx-apps#3430

[lupyuen]

@masc2008 Can you Rebase with Master Branch to trigger the CI Build? Thanks :-)

[masc2008]

@masc2008 Can you Rebase with Master Branch to trigger the CI Build? Thanks :-)

I just did: "git pull upstream" and "git push", the "rebase" should be finished, am I correct?

[lupyuen]

Yep it's building now thanks :-)

[xiaoxiang781216]

Suggested change

	static mutex_t g_nat_lock = NXRMUTEX_INITIALIZER;
	static rmutex_t g_nat_lock = NXRMUTEX_INITIALIZER;