Skip to content

MINIFICPP-2751 Remove MinifiStatusToString before C Api is finalized#2140

Open
martinzink wants to merge 1 commit intoapache:mainfrom
martinzink:reduce_c_api
Open

MINIFICPP-2751 Remove MinifiStatusToString before C Api is finalized#2140
martinzink wants to merge 1 commit intoapache:mainfrom
martinzink:reduce_c_api

Conversation

@martinzink
Copy link
Member

Since these are well known static string literals we can omit this function from the C API, and let the consumers implement it if they require it.


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

Copy link
Member

@szaszm szaszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this function is useful, and I'd consider reintroducing it later, but I can support removing it now, to minimize the initial API, and reduce the surface that we need to get right before 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants