Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17295 +/- ##
=========================================
Coverage 39.76% 39.76%
Complexity 282 282
=========================================
Files 5100 5100
Lines 342150 342121 -29
Branches 43596 43593 -3
=========================================
+ Hits 136044 136055 +11
+ Misses 206106 206066 -40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jt2594838
reviewed
Mar 24, 2026
Comment on lines
+105
to
+114
| // Create an ordinary full sync pipe | ||
| // The database & table name will be converted to lower case | ||
| final String sql = | ||
| String.format("create pipe a2b ('node-urls'='%s')", receiverDataNode.getIpAndPortString()); | ||
| try (final Connection connection = senderEnv.getConnection(BaseEnv.TABLE_SQL_DIALECT); | ||
| final Statement statement = connection.createStatement()) { | ||
| statement.execute(sql); | ||
| } catch (SQLException e) { | ||
| fail(e.getMessage()); | ||
| } |
Contributor
There was a problem hiding this comment.
"The database & table name will be converted to lower case"
I do not see any database or table name here.
Comment on lines
+142
to
+143
| if (!pipeName.contains(PipeStaticMeta.CONSENSUS_PIPE_PREFIX) | ||
| && pipeName.endsWith("_history")) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As the title said.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR