IGNITE-27934 Fix flaky GridBinaryAffinityKeySelfTest#testAffinity#12896
Open
zstan wants to merge 1 commit intoapache:masterfrom
Open
IGNITE-27934 Fix flaky GridBinaryAffinityKeySelfTest#testAffinity#12896zstan wants to merge 1 commit intoapache:masterfrom
zstan wants to merge 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes flakiness in GridBinaryAffinityKeySelfTest#testAffinity by adding an explicit wait intended to ensure topology-related state is updated before running affinity assertions on a newly started node.
Changes:
- Added
GridTestUtilsdependency to the test. - Introduced a
waitForConditionassertion to wait for a minor topology version change before callingcheckAffinity(igniteNoCache).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+105
to
+108
| assertTrue("Failed to wait for minor version change", | ||
| GridTestUtils.waitForCondition(() -> | ||
| grid(0).context().discovery().topologyVersionEx().minorTopologyVersion() == 1, | ||
| 5_000)); |
zstan
force-pushed
the
ignite-27934
branch
2 times, most recently
from
c1c0bb9 to
c8e0e3d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.