IGNITE-28036 Fix flaky IgniteOfflineBaselineNodeFullApiSelfTest#12843
Open
abashev wants to merge 1 commit intoapache:masterfrom
Open
IGNITE-28036 Fix flaky IgniteOfflineBaselineNodeFullApiSelfTest#12843abashev wants to merge 1 commit intoapache:masterfrom
abashev wants to merge 1 commit intoapache:masterfrom
Conversation
abashev
force-pushed
the
feature/IGNITE-28036
branch
from
6f3ce7a to
ddbe690
Compare
|
zstan
reviewed
Mar 17, 2026
|
|
||
| if (delta <= 0) { | ||
| removeValue(); | ||
| cctx.shared().database().checkpointReadLock(); |
Contributor
There was a problem hiding this comment.
- do we really need this lock ?
- can we cover with appropriate test such a case for defence in future ?
Contributor
Author
There was a problem hiding this comment.
Yes, we have that test - IgniteOfflineBaselineNodeFullApiSelfTest, it crashes all the time and this is a fix for it.
Contributor
There was a problem hiding this comment.
Not sure such easy fix is a proper solution.
The question is why none of 16 cctx.shared().database().checkpointReadLock(); usages helped.
The solution is not to hold lock, but to understand why it's not held.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see tabPR Checkat TC.Bot - Instance 1 or TC.Bot - Instance 2)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.