Core, Open-API: Add server-side warehouse validation for /v1/config endpoint#16247
Draft
kevinjqliu wants to merge 4 commits intoapache:mainfrom
Draft
Core, Open-API: Add server-side warehouse validation for /v1/config endpoint#16247kevinjqliu wants to merge 4 commits intoapache:mainfrom
kevinjqliu wants to merge 4 commits intoapache:mainfrom
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds server-side warehouse validation to the REST catalog test fixture server, complementing the client-side changes in #16059.
When a
warehousequery parameter is provided to/v1/configthat doesn't match the configured warehouse, the server returns a404 NoSuchWarehouseException.Testing
Build and run the REST catalog server locally:
./gradlew :iceberg-open-api:shadowJar -x test CATALOG_WAREHOUSE=mywarehouse java -jar open-api/build/libs/iceberg-open-api-test-fixtures-runtime-1.12.0-SNAPSHOT.jarhttp://localhost:8181/v1/config -> 200
http://localhost:8181/v1/config?warehouse=mywarehouse -> 200, matches
CATALOG_WAREHOUSEhttp://localhost:8181/v1/config?warehouse=thisdoesntexist -> 404