#15510 Parquet: Support row group skipping for shredded variant columns#16133
Draft
steveloughran wants to merge 8 commits intoapache:mainfrom
Draft
#15510 Parquet: Support row group skipping for shredded variant columns#16133steveloughran wants to merge 8 commits intoapache:mainfrom
steveloughran wants to merge 8 commits intoapache:mainfrom
Conversation
Contributor
Author
|
This doesn't get called from spark until multiple PRs are merged: |
ParquetMetricsRowGroupFilter.compareVariant() implements comparisons for variants, including NaN, null. * New ParquetVariantUtil splitter regexp can't cope with columns called ]. That's OK as normalisation forbids that and empty paths * Copilot wrote the tests so it's over-verbose, but thorough. * including NaN behaviour and string truncation on max values.
steveloughran
force-pushed
the
pr/variant-rowgroups
branch
from
308001d to
a10c7e5
Compare
Goal: speedup rather than slow-down
steveloughran
force-pushed
the
pr/variant-rowgroups
branch
from
a10c7e5 to
8474d0d
Compare
There's no concurrency handling here in the build up of that lazy structure, BTW...once happy with the design it'll need to be locked down better.
…kipping copilot's solution to why pushdown wasn't working, independent of qlong's apache#15385 I plan to take qlong's and pull what is extra from this one.
+ add set membership probe + logging at info off pr/variant-rowgroups-benchmark removed the IcebergSourceVariantIOBenchmark changes.
+ adjust ParquetMetricsRowGroupFilter to keep filter complexity below 13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParquetMetricsRowGroupFilter.compareVariant() implements comparisons for variants, including NaN, null.
Fixes #15510
Testing notes
Full branch with this, Qlong's api changes and the benchmark is https://github.com/steveloughran/iceberg/tree/pr/variant-rowgroups-benchmark
Does need a matching spark version.