feat: support V0 iceberg_tables schema for SqlCatalog #2380
Open
rchowell wants to merge 2 commits intoapache:mainfrom
Open
feat: support V0 iceberg_tables schema for SqlCatalog #2380rchowell wants to merge 2 commits intoapache:mainfrom
rchowell wants to merge 2 commits intoapache:mainfrom
Conversation
blackmwk
reviewed
Apr 29, 2026
rchowell
changed the title
Contributor
Author
|
Ok @blackmwk thanks again for reviewing, I was mistaken and have fixed this PR to match iceberg-java much more closely. I also updated the PR title and description to be more accurate since this is more of a feature to support reading V0 tables in iceberg-rust. Thanks! |
rchowell
commented
May 1, 2026
Comment on lines
43
to
46
| pub const SQL_CATALOG_PROP_BIND_STYLE: &str = "sql_bind_style"; | ||
| /// catalog schema version, setting to "V1" will migrate from V0 to V1 schema | ||
| pub const SQL_CATALOG_PROP_SCHEMA_VERSION: &str = "sql.schema-version"; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Seeing these together makes me think sql_schema_version yet iceberg-java has jdbc.schema-version. I do prefer consistency for something like sql.<kebab>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This PR adds support for using a V0 SqlCatalog from other implementations like iceberg-python or iceberg-java, and it follows the iceberg-java behavior of checking an explicit
schema-versionproperty and migrating to V1 only-if the user requested this. I also added logging at the same level as iceberg-java.Probe to see if we have a V0 or V1 table, then add the iceberg_type column if it does not exist. More details in apache/iceberg-python#3263
Are these changes tested?