REST: Add pagination support for list_views#3349
Open
ebyhr wants to merge 2 commits intoapache:mainfrom
Open
Conversation
geruh
reviewed
May 10, 2026
| # Build URL with pagination params | ||
| url = self.url(Endpoints.list_views, namespace=namespace_concat) | ||
| if page_token: | ||
| url = f"{url}?pageToken={page_token}" |
Member
There was a problem hiding this comment.
This should use a param map instead of string concatenation to pass in pageToken. Especially because the token is defined as an opaque string that can contain symbols that could be messed up by encoding.
| view_response = ViewResponse.model_validate_json(response.text) | ||
| return self._response_to_view(self.identifier_to_tuple(identifier), view_response) | ||
| while True: | ||
| # Build URL with pagination params |
Member
There was a problem hiding this comment.
nit: unnecessary comment with this and below since code is demonstrating this alr
| assert RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN).list_views(namespace) == [("examples", "fooshare")] | ||
|
|
||
|
|
||
| def test_list_views_paginated_200(rest_mock: Mocker) -> None: |
Member
There was a problem hiding this comment.
Can we add some tests for an ommitted field and null for the next_page_token, and ensure the behavior is the same?
ebyhr
force-pushed
the
ebi/rest-page-views
branch
from
9b3e652 to
553a73a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Follows REST catalog spec:
Are these changes tested?
Yes, includes unit tests for paginated cases.
Are there any user-facing changes?