Skip to content

RFC 9111 allows max-stale without a value (accept any staleness). Treat missing value as unbounded #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arturobernalg merged 1 commit into from
Feb 18, 2026
Merged

RFC 9111 allows max-stale without a value (accept any staleness). Treat missing value as unbounded #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheControlHeaderParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,11 @@ public final RequestCacheControl parseRequest(final Iterator<Header> headerItera
if (name.equalsIgnoreCase(HeaderConstants.CACHE_CONTROL_MAX_AGE)) {
builder.setMaxAge(parseSeconds(name, value));
} else if (name.equalsIgnoreCase(HeaderConstants.CACHE_CONTROL_MAX_STALE)) {
builder.setMaxStale(parseSeconds(name, value));
if (value == null) {
builder.setMaxStale(Long.MAX_VALUE);
} else {
builder.setMaxStale(parseSeconds(name, value));
}
} else if (name.equalsIgnoreCase(HeaderConstants.CACHE_CONTROL_MIN_FRESH)) {
builder.setMinFresh(parseSeconds(name, value));
} else if (name.equalsIgnoreCase(HeaderConstants.CACHE_CONTROL_NO_STORE)) {
Expand Down
19 changes: 19 additions & 0 deletions ...nt5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/CacheControlParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,4 +259,23 @@ void testParseMultipleIsImmutable() {
assertTrue(cacheControl.isImmutable());
}

@Test
void testParseRequestMaxStaleWithoutValue() {
// RFC 9111: "max-stale" without a value means accept any staleness
final Header header = new BasicHeader("Cache-Control", "max-stale");
final RequestCacheControl cacheControl = parser.parseRequest(Collections.singletonList(header).iterator());

assertEquals(Long.MAX_VALUE, cacheControl.getMaxStale());
}

@Test
void testParseRequestMaxStaleEmptyValueIsInvalid() {
// "max-stale=" is not the same as bare "max-stale" (missing delta-seconds)
final Header header = new BasicHeader("Cache-Control", "max-stale=");
final RequestCacheControl cacheControl = parser.parseRequest(Collections.singletonList(header).iterator());

assertEquals(-1L, cacheControl.getMaxStale());
}


}
Loading