HIVE-27193: Database names starting with '@' cause error during ALTER… by ashniku · Pull Request #6371 · apache/hive

ashniku · 2026-03-16T12:18:55Z

…/DROP table

What changes were proposed in this pull request?
I have mofified "MetaStoreUtils.java", updated "hasCatalogName" to return true only if the database name both starts with the catalog marker (@) and contains the catalog-database separator (#).
-->

Why are the changes needed?
The issue is caused by MetaStoreUtils.hasCatalogName incorrectly identifying database names that start with the '@' character as catalog-prepended names. This leads to a failure in MetaStoreUtils.parseDbName when it tries to split the name using the '#' separator, which is missing in regular database names starting with '@'.

Proposed Changes
[Metastore Common]
[MODIFY] MetaStoreUtils.java
Update hasCatalogName
to return true only if the database name both starts with the catalog marker (@) and contains the catalog-database separator (#).

Does this PR introduce any user-facing change?
NO
-->

How was this patch tested?
CREATE DATABASE @test;
USE @test;
CREATE TABLE testtable (c1 INT);
ALTER TABLE testtable ADD COLUMNS (c2 INT);
DROP TABLE testtable;
DROP DATABASE @test;

ashniku

can someone please review

Neer393 · 2026-03-17T16:32:37Z

CI is failing. Can you please fix it first ?

ashniku · 2026-03-18T10:48:06Z

closing the PR, I will re-open again

ashniku · 2026-03-18T10:52:25Z

retest this please

Neer393 · 2026-03-18T17:10:06Z

@@ -0,0 +1,6 @@
+CREATE DATABASE `@test`;


Please use meaningful test file names that can help understand the purpose of the qtest file in future

Neer393 · 2026-03-18T17:10:19Z

@@ -0,0 +1,44 @@
+PREHOOK: query: CREATE DATABASE `@test`


Same for this

Neer393 · 2026-03-18T17:15:03Z

+CREATE DATABASE `@test`;
+USE `@test`;
+CREATE TABLE testtable (c1 INT);
+ALTER TABLE testtable ADD COLUMNS (c2 INT);


Instead of using the database and alter and drop table, can you run the query as mentioned in the JIRA as I see that the issue is seen when hive tries to parse dbName.tableName where the dbName has the special character @ as it looks out for the catalog name.

Change queries to

ALTER TABLE `@test`.testtable ADD COLUMNS (c2 INT); DROP TABLE `@test`.testtable;

You should also create another table named testtable2 and try the following queries as well

ALTER TABLE `@hive#@test`.testtable ADD COLUMNS (c2 INT); DROP TABLE `@hive#@test`.testtable;

@Neer393 The Jira was created
ALTER TABLE @test.testtable ADD COLUMNS (c2 INT);
DROP TABLE @test.testtable;
This above one succeeds.

I just have a doubt on below:

ALTER TABLE @hive#test.testtable ADD COLUMNS (c2 INT);
DROP TABLE @hive#test.testtable;In this case @hive#test the whole word is database or it is deciphered as catalog#database. The purpose is to check with @ as per the kita.

Could you please let me know??

Can you please confirm if below needs to be executed:

create database@hive#test; create table @hive#test.testtable (c1 INT); ALTER TABLE @hive#test.testtable ADD COLUMNS (c2 INT); DROP TABLE @hive#test.testtable;

In that case this works? Can you please confirm, so that I can put in qtest

In this case @hive#test the whole word is database or it is deciphered as catalog#database. The purpose is to check with @ as per the kita.

It is deciphered as @catalog#database
So as per this JIRA, ALTER TABLE queries are failing because they call the MetastoreUtils.parseDbName() method which is calling the MetastoreUtils.hasCatalogName() method which you have fixed but the purpose of parseDbName is that it should return an array of size 2 where the 1st element is catalog name and the 2nd element is the database name.

So just to make sure both with and without catalog name works, I have asked you to run both queries

CREATE DATABASE `@test`; CREATE TABLE `@test`.testtable (c1 INT); ALTER TABLE `@hive#@test`.testtable ADD COLUMNS (c2 INT); DROP TABLE `@hive#@test`.testtable; DROP DATABASE `@test`;

@Neer393 I have addressed the TestDanglingQOuts failure by promoting the result file to the correct directory: ql/src/test/results/clientpositive/llap/hive_27193.q.out.

Tests: The test case hive_27193 is now correctly integrated into the LLAP test suite.

Could you please trigger the Hive QA (Jenkins) run again when you have a moment? Thank you!"

…/DROP table

…e to llap directory.

…n reviewer feedback

…tore-server

…haracter.q.out

…s in parseDbName

…ompilation without JUnit 5

zabetak · 2026-03-27T12:34:54Z

+    assertArrayEquals(new String[]{"cat1", null}, parseDbName("@cat1", conf));
+    assertArrayEquals(new String[]{"cat1", null}, parseDbName("@cat1#", conf));
+    assertArrayEquals(new String[]{"cat1", ""}, parseDbName("@cat1#!", conf));
+    assertArrayEquals(new String[]{"cat1", "@db1"}, parseDbName("@cat1#@db1", conf));
+    assertArrayEquals(new String[]{"cat1", "#db1"}, parseDbName("@cat1##db1", conf));
+    assertArrayEquals(new String[]{"cat1", "db1"}, parseDbName("@cat1#db1", conf));
+    assertArrayEquals(new String[]{"cat1", "db1!"}, parseDbName("@cat1#db1!", conf));
+    assertArrayEquals(new String[]{"cat1!", null}, parseDbName("@cat1!", conf));
+    assertArrayEquals(new String[]{"hive", "#db1"}, parseDbName("#db1", conf));
+    assertArrayEquals(new String[]{"hive", "#!"}, parseDbName("#!", conf));
+    assertArrayEquals(new String[]{"hive", "#"}, parseDbName("#", conf));


All these test cases are duplicated below and some even contradict each other. This test is probably not passing as it is.

As a side note keep in mind that CI resources are limited so be mindful about pushing things in the PR that are guaranteed to fail.

@zabetak

removed duplicates and only below test are present

assertArrayEquals(new String[]{"hive", "@"}, parseDbName("@", conf)); assertArrayEquals(new String[]{"hive", "@!"}, parseDbName("@!", conf)); assertArrayEquals(new String[]{"", null}, parseDbName("@#", conf)); assertArrayEquals(new String[]{"", "db1"}, parseDbName("@#db1", conf)); assertArrayEquals(new String[]{"hive", "@cat1"}, parseDbName("@cat1", conf)); assertArrayEquals(new String[]{"cat1", null}, parseDbName("@cat1#", conf)); assertArrayEquals(new String[]{"cat1", ""}, parseDbName("@cat1#!", conf)); assertArrayEquals(new String[]{"cat1", "@db1"}, parseDbName("@cat1#@db1", conf)); assertArrayEquals(new String[]{"cat1", "#db1"}, parseDbName("@cat1##db1", conf)); assertArrayEquals(new String[]{"cat1", "db1"}, parseDbName("@cat1#db1", conf)); assertArrayEquals(new String[]{"cat1", "db1!"}, parseDbName("@cat1#db1!", conf)); assertArrayEquals(new String[]{"hive", "@cat1!"}, parseDbName("@cat1!", conf)); assertArrayEquals(new String[]{"hive", "#db1"}, parseDbName("#db1", conf)); assertArrayEquals(new String[]{"hive", "#!"}, parseDbName("#!", conf)); assertArrayEquals(new String[]{"hive", "#"}, parseDbName("#", conf));

Drop duplicated and contradictory parseDbName expectations; keep a single assert per edge-case input aligned with hasCatalogName (@ plus #) behavior. Made-with: Cursor

Made-with: Cursor

ashniku

@zabetak The CI has failed for one test:

Error expected:<1> but was:<0> Stacktrace java.lang.AssertionError: expected:<1> but was:<0> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.junit.Assert.assertEquals(Assert.java:633) at org.apache.hadoop.hive.ql.parse.repl.metric.TestReplicationMetricCollector.testSuccessOptimizedBootstrapDumpMetrics(TestReplicationMetricCollector.java:286) at java.base/java.lang.reflect.Method.invoke(Method.java:580) at org.mockito.internal.runners.DefaultInternalRunner$1$1.evaluate(DefaultInternalRunner.java:55) at org.mockito.internal.runners.DefaultInternalRunner$1.run(DefaultInternalRunner.java:100) at org.mockito.internal.runners.DefaultInternalRunner.run(DefaultInternalRunner.java:107) at org.mockito.internal.runners.StrictRunner.run(StrictRunner.java:42) at org.mockito.junit.MockitoJUnitRunner.run(MockitoJUnitRunner.java:163) Standard Error 2026-03-31T07:18:52,313 WARN [main] conf.HiveConf: HiveConf of name hive.dummyparam.test.server.specific.config.override does not exist 2026-03-31T07:18:52,314 WARN [main] conf.HiveConf: HiveConf of name hive.dummyparam.test.server.specific.config.hivesite does not exist 2026-03-31T07:18:52,315 WARN [main] conf.HiveConf: HiveConf of name hive.dummyparam.test.server.specific.config.metastoresite does not exist

Is this related to my change or its flaky??

zabetak · 2026-04-02T08:31:45Z

@ashniku The test failure in testSuccessOptimizedBootstrapDumpMetrics does not seem related to the change so I triggered another CI run.

zabetak

LGTM pending tests. I will merge this tomorrow. If there are any objections let me know.

ashniku · 2026-04-02T09:12:42Z

Error expected:<1> but was:<0> Stacktrace java.lang.AssertionError: expected:<1> but was:<0> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.junit.Assert.assertEquals(Assert.java:633) at org.apache.hadoop.hive.ql.parse.repl.metric.TestReplicationMetricCollector.testSuccessOptimizedBootstrapDumpMetrics(TestReplicationMetricCollector.java:286) at java.base/java.lang.reflect.Method.invoke(Method.java:580) at org.mockito.internal.runners.DefaultInternalRunner$1$1.evaluate(DefaultInternalRunner.java:55) at org.mockito.internal.runners.DefaultInternalRunner$1.run(DefaultInternalRunner.java:100) at org.mockito.internal.runners.DefaultInternalRunner.run(DefaultInternalRunner.java:107) at org.mockito.internal.runners.StrictRunner.run(StrictRunner.java:42) at org.mockito.junit.MockitoJUnitRunner.run(MockitoJUnitRunner.java:163) Standard Error 2026-03-31T07:18:52,313 WARN [main] conf.HiveConf: HiveConf of name hive.dummyparam.test.server.specific.config.override does not exist 2026-03-31T07:18:52,314 WARN [main] conf.HiveConf: HiveConf of name hive.dummyparam.test.server.specific.config.hivesite does not exist 2026-03-31T07:18:52,315 WARN [main] conf.HiveConf: HiveConf of name hive.dummyparam.test.server.specific.config.metastoresite does not exist

LGTM pending tests. I will merge this tomorrow. If there are any objections let me know.

Thank you for your help @zabetak . I dont have anything from my end :)

sonarqubecloud · 2026-04-02T09:58:56Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

asf-ci-hive added tests pending tests failed and removed tests pending labels Mar 16, 2026

ashniku marked this pull request as ready for review March 16, 2026 12:24

asf-ci-hive added tests pending tests failed and removed tests failed tests pending labels Mar 16, 2026

ashniku commented Mar 16, 2026

View reviewed changes

asf-ci-hive added tests pending tests failed and removed tests failed tests pending labels Mar 18, 2026

ashniku force-pushed the HIVE-27193 branch from 3f24df5 to 00b8b27 Compare March 18, 2026 10:21

ashniku closed this Mar 18, 2026

ashniku reopened this Mar 18, 2026

asf-ci-hive added tests pending and removed tests failed labels Mar 18, 2026

Neer393 reviewed Mar 18, 2026

View reviewed changes

asf-ci-hive added tests unstable and removed tests pending labels Mar 18, 2026

ashniku requested a review from Neer393 March 19, 2026 05:47

ashniku force-pushed the HIVE-27193 branch from 00b8b27 to 56157e4 Compare March 19, 2026 15:15

asf-ci-hive added tests pending and removed tests unstable labels Mar 19, 2026

asf-ci-hive added tests pending tests failed and removed tests failed tests pending labels Mar 27, 2026

ashniku added 15 commits March 27, 2026 17:57

HIVE-27193: Database names starting with '@' cause error during ALTER…

cf34861

…/DROP table

Update hive_27193.q and its results for LLAP. Use @FirstDB and promot…

adf24e5

…e to llap directory.

Rename test file hive_27193.q to database_special_character.q

fc177d9

Triggering Jenkins retest

de09fab

Triggering Jenkins CI re-run

d9471a7

Triggering Jenkins CI re-run

9605213

HIVE-27193: Fix parseDbName for edge cases and add unit tests

a38a36f

HIVE-27193: Refine parseDbName logic and modernize unit tests based o…

d51538d

…n reviewer feedback

HIVE-27193: Re-add junit-jupiter-api for classpath alignment in metas…

d71ed19

…tore-server

Triggering Jenkins CI re-run

66f647b

HIVE-27193: Fix dangling qout by removing leftover database_special_c…

d7706d0

…haracter.q.out

HIVE-27193: Fix Sonar and reviewer comments for parseDbName

0e30e7f

HIVE-27193: Fix catalog parsing bug and expand parseDbName test cases

2a86770

HIVE-27193: Fix catalog parsing bug and verify all provided edge case…

50beb17

…s in parseDbName

HIVE-27193: Restore system-stubs-core (v1.2.0) to fix HTTP JWT test c…

c267df6

…ompilation without JUnit 5

ashniku force-pushed the HIVE-27193 branch from e2e8c86 to c267df6 Compare March 27, 2026 12:28

zabetak requested changes Mar 27, 2026

View reviewed changes

HIVE-27193: Remove duplicate assertions in TestMetastoreUtilsParseDbName

e70c820

Drop duplicated and contradictory parseDbName expectations; keep a single assert per edge-case input aligned with hasCatalogName (@ plus #) behavior. Made-with: Cursor

zabetak requested changes Mar 30, 2026

View reviewed changes

Comment thread standalone-metastore/metastore-server/pom.xml Outdated

ashniku and others added 2 commits March 31, 2026 00:10

Remove system-stubs-core from metastore-server pom

168ae42

Made-with: Cursor

Revert all changes in pom.xml

066a151

ashniku commented Mar 31, 2026

View reviewed changes

zabetak approved these changes Apr 2, 2026

View reviewed changes

Conversation

ashniku commented Mar 16, 2026

Uh oh!

ashniku left a comment

Choose a reason for hiding this comment

Uh oh!

Neer393 commented Mar 17, 2026

Uh oh!

ashniku commented Mar 18, 2026

Uh oh!

ashniku commented Mar 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Neer393 Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ashniku left a comment

Choose a reason for hiding this comment

Uh oh!

zabetak commented Apr 2, 2026

Uh oh!

zabetak left a comment

Choose a reason for hiding this comment

Uh oh!

ashniku commented Apr 2, 2026

Uh oh!

sonarqubecloud Bot commented Apr 2, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Neer393 Mar 18, 2026 •

edited

Loading