Skip to content

HBASE-29961 Secondary cluster is unable to replayWAL for meta#7854

Merged
anmolnar merged 1 commit intoapache:HBASE-29081from
sharmaar12:replayWAL
Mar 9, 2026
Merged

HBASE-29961 Secondary cluster is unable to replayWAL for meta#7854
anmolnar merged 1 commit intoapache:HBASE-29081from
sharmaar12:replayWAL

Conversation

@sharmaar12
Copy link
Copy Markdown

No description provided.

@sharmaar12 sharmaar12 marked this pull request as ready for review March 5, 2026 11:28
Copy link
Copy Markdown
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Copy link
Copy Markdown
Contributor

@Kota-SH Kota-SH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anmolnar anmolnar merged commit e0bbbc5 into apache:HBASE-29081 Mar 9, 2026
sharmaar12 added a commit to sharmaar12/hbase that referenced this pull request Mar 10, 2026
sharmaar12 added a commit to sharmaar12/hbase that referenced this pull request Mar 12, 2026
sharmaar12 added a commit to sharmaar12/hbase that referenced this pull request Mar 13, 2026
sharmaar12 added a commit to sharmaar12/hbase that referenced this pull request Mar 17, 2026
sharmaar12 added a commit to sharmaar12/hbase that referenced this pull request Mar 26, 2026
sharmaar12 added a commit to sharmaar12/hbase that referenced this pull request Mar 26, 2026
anmolnar added a commit that referenced this pull request Mar 26, 2026
* HBASE-29958 Improve log messages

* Address review comments

* Update hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java

Co-authored-by: Kota-SH <shanmukhaharipriya@gmail.com>

* Update hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java

Co-authored-by: Kota-SH <shanmukhaharipriya@gmail.com>

* Update hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java

Co-authored-by: Kota-SH <shanmukhaharipriya@gmail.com>

* HBASE-29961 Secondary cluster is unable to replayWAL for meta (#7854)

* Add <blank> when no suffix provided

* Address few review comments

* HBASE-29958. Refactor ActiveClusterSuffix to use protobuf, refactor logging

* HBASE-29958. Remove more redundant logic, test cleanup

* HBASE-29958. Spotless apply

* HBASE-29958. Revert mistake

* HBASE-29958 Improve log messages

* Address Kevin's review comment to address multiple : in active cluster suffix

* As getClusterSuffixFromConfig() changed we need to change the code for file deletion

* Use ActiveClusterSuffix object based comparison instead of byte Array comparison

---------

Co-authored-by: Kota-SH <shanmukhaharipriya@gmail.com>
Co-authored-by: Andor Molnar <andor@cloudera.com>
anmolnar added a commit that referenced this pull request Apr 8, 2026
* HBASE-29958 Improve log messages

* Address review comments

* Update hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java

Co-authored-by: Kota-SH <shanmukhaharipriya@gmail.com>

* Update hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java

Co-authored-by: Kota-SH <shanmukhaharipriya@gmail.com>

* Update hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java

Co-authored-by: Kota-SH <shanmukhaharipriya@gmail.com>

* HBASE-29961 Secondary cluster is unable to replayWAL for meta (#7854)

* Add <blank> when no suffix provided

* Address few review comments

* HBASE-29958. Refactor ActiveClusterSuffix to use protobuf, refactor logging

* HBASE-29958. Remove more redundant logic, test cleanup

* HBASE-29958. Spotless apply

* HBASE-29958. Revert mistake

* HBASE-29958 Improve log messages

* Address Kevin's review comment to address multiple : in active cluster suffix

* As getClusterSuffixFromConfig() changed we need to change the code for file deletion

* Use ActiveClusterSuffix object based comparison instead of byte Array comparison

---------

Co-authored-by: Kota-SH <shanmukhaharipriya@gmail.com>
Co-authored-by: Andor Molnar <andor@cloudera.com>
anmolnar added a commit that referenced this pull request Apr 10, 2026
* HBASE-29958 Improve log messages

* Address review comments

* Update hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java

Co-authored-by: Kota-SH <shanmukhaharipriya@gmail.com>

* Update hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java

Co-authored-by: Kota-SH <shanmukhaharipriya@gmail.com>

* Update hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java

Co-authored-by: Kota-SH <shanmukhaharipriya@gmail.com>

* HBASE-29961 Secondary cluster is unable to replayWAL for meta (#7854)

* Add <blank> when no suffix provided

* Address few review comments

* HBASE-29958. Refactor ActiveClusterSuffix to use protobuf, refactor logging

* HBASE-29958. Remove more redundant logic, test cleanup

* HBASE-29958. Spotless apply

* HBASE-29958. Revert mistake

* HBASE-29958 Improve log messages

* Address Kevin's review comment to address multiple : in active cluster suffix

* As getClusterSuffixFromConfig() changed we need to change the code for file deletion

* Use ActiveClusterSuffix object based comparison instead of byte Array comparison

---------

Co-authored-by: Kota-SH <shanmukhaharipriya@gmail.com>
Co-authored-by: Andor Molnar <andor@cloudera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants