Simplify tests#1222
Merged
Merged
Conversation
Move common UI functional test fixtures into a shared test project to reduce duplication. Add `LifecyclePage` so tests can reliably detect a full page reload, even when navigation transitions back to the same page type. Extract form classes to make each web form's available inputs explicit.
The functional tests are divided over multiple "configs" that are triggered by setting a TESTCONFIG system property. This script will loop through all current available TESTCONFIG values and run them. This functionality is already exercised in CI, and this script makes also makes it easy to run all tests locally.
bkoehm
approved these changes
May 12, 2026
Contributor
bkoehm
left a comment
bkoehm
left a comment
There was a problem hiding this comment.
I don't see any issues however I cannot verify that all tests pass in my local environment as I have trouble with docker in my local setup: "...attempts to find a Docker environment failed". I approve, but I recommend that another reviewer with a working docker setup verify that all the tests pass before this PR is merged.
jdaugherty
approved these changes
May 16, 2026
Contributor
jdaugherty
left a comment
jdaugherty
left a comment
There was a problem hiding this comment.
Can we make sure the same # of tests ran? If so, I'm good to approve.
Contributor
Author
Confirmed same # of tests are running. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move common UI functional test fixtures into a shared test project to
reduce duplication.
Add
LifecyclePageso tests can reliably detect a full page reload, evenwhen navigation transitions back to the same page type.
Extract form classes to make each web form's available inputs explicit.