FELIX-6829 Remove http.jetty dependency on commons-fileupload

[enapps-enorman]

Jetty does not need the Apache commons-fileupload library. Modern versions of Jetty support the Java Servlet Specification (3.0 and newer), which includes built-in, native APIs to parse multipart/form-data requests.

Refactoring to use the standard servlet apis:

1. remove the commons-fileupload dependency
2. Change ServletRequestMultipartWrapper to delegate the multipart request handling to the jetty servlet container
3. Other refactoring to replace the org.apache.commons.fileupload references with the servlet Part equivalent

[enapps-enorman]

I believe the now unused ServletHandler#getMultipartSecurityContext and related code could also be removed since the only usage was in the now removed multipart handling code.

But I thought I would get some feedback on the general approach before doing that extra cleanup.

UPDATE: cleaned up the the dead code at 3627401

[paulrutter]

@enapps-enorman I like the approach, it's just another dependency we can do without nowadays. I'm fine with removing and delegation to Jetty instead.

[cziegeler]

I suggest to run the OSGi TCK for the http service, http whiteboard and servlet whiteboard on the proposed change.

[enapps-enorman]

I suggest to run the OSGi TCK

For clarification, is that referring to the test cases published at https://github.com/osgi/osgi or something private I don't have access to? If it is the former then I tried running it against org.apache.felix.http.jetty-5.2.3-SNAPSHOT and I didn't get any test failures.

[cziegeler]

Yes, it is that public git repo, you need to run the test cases from the R8 cmpn release:

• https://github.com/osgi/osgi/tree/r8-cmpn-final/org.osgi.test.cases.http
• https://github.com/osgi/osgi/tree/r8-cmpn-final/org.osgi.test.cases.http.whiteboard
• https://github.com/osgi/osgi/tree/r8-cmpn-final/org.osgi.test.cases.http.whiteboard.secure

and R8.1 cmpn release:

• https://github.com/osgi/osgi/tree/8.1.0.cmpn/org.osgi.test.cases.servlet
• https://github.com/osgi/osgi/tree/8.1.0.cmpn/org.osgi.test.cases.servlet.secure