Skip to content

ci: build generated types before type check#21631

Closed
Justin-ZS wants to merge 1 commit into
masterfrom
codex/fix-ci-checktype-generated-types
Closed

ci: build generated types before type check#21631
Justin-ZS wants to merge 1 commit into
masterfrom
codex/fix-ci-checktype-generated-types

Conversation

@Justin-ZS
Copy link
Copy Markdown
Contributor

Summary

  • build generated library types in the lint job before running npm run checktype
  • prevents cached node_modules from skipping npm ci and leaving types/dist/echarts missing

Root Cause

The lint job skips npm ci when the node_modules cache hits. Since npm ci is what normally runs prepare -> build:lib, generated type files may be absent before checktype.

Validation

  • npm ci
  • npm run build:lib && npm run checktype
  • commit hook: npm run lint and npm run checktype

@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented May 27, 2026

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged

This message is shown because the PR description doesn't contain the document related template.

@Justin-ZS Justin-ZS closed this May 27, 2026
@plainheart plainheart deleted the codex/fix-ci-checktype-generated-types branch May 28, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant