[refine](hashmap)The iterator for the agg hashmap should not yield NULL values.#61113
Merged
BiteTheDDDDt merged 1 commit intoapache:masterfrom Mar 11, 2026
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 27843 ms |
TPC-DS: Total hot run time: 153587 ms |
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Mryange
changed the title
Mryange
force-pushed
the
refine-hashmap-iter-not-contian-null
branch
from
f21dc7d to
aa2acf4
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 27720 ms |
TPC-DS: Total hot run time: 152959 ms |
Mryange
force-pushed
the
refine-hashmap-iter-not-contian-null
branch
from
aa2acf4 to
c744f5f
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 27711 ms |
TPC-DS: Total hot run time: 153956 ms |
BiteTheDDDDt
approved these changes
Mar 10, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 27798 ms |
TPC-DS: Total hot run time: 153888 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 27856 ms |
TPC-DS: Total hot run time: 153813 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Mryange
added a commit
to Mryange/doris
that referenced
this pull request
Mar 13, 2026
…LL values. (apache#61113) ### What problem does this PR solve? In the PR apache#51063, because the hashmap did not handle NULL values in one operation, it caused a correctness issue. To fix it, the iterator for a hashmap that contains NULL may return NULL values. However, this is not ideal. A hashmap can contain at most one NULL key, and our usual approach is to handle this NULL key either at the end or at the beginning. In other cases, there is no need to consider NULL, and this is also better for performance. This PR ensures that the iterator for the agg hashmap should not yield NULL values. ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [x] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In the PR #51063, because the hashmap did not handle NULL values in one operation, it caused a correctness issue. To fix it, the iterator for a hashmap that contains NULL may return NULL values. However, this is not ideal. A hashmap can contain at most one NULL key, and our usual approach is to handle this NULL key either at the end or at the beginning. In other cases, there is no need to consider NULL, and this is also better for performance.
This PR ensures that the iterator for the agg hashmap should not yield NULL values.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)