Skip to content

fix(bench): avoid OOM in array_replace bench #22120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
May 12, 2026
+6 −11
Merged

fix(bench): avoid OOM in array_replace bench #22120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions datafusion/functions-nested/benches/array_expression.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,27 +23,22 @@ use std::hint::black_box;
fn criterion_benchmark(c: &mut Criterion) {
// Construct large arrays for benchmarking

let array_len = 100000000;
let array_len = 100_000;

let array = (0..array_len).map(|_| lit(2_i64)).collect::<Vec<_>>();
let list_array = make_array(vec![make_array(array); 3]);
let from_array = make_array(vec![lit(2_i64); 3]);
let to_array = make_array(vec![lit(-2_i64); 3]);

let expected_array = list_array.clone();

// Benchmark array functions

c.bench_function("array_replace", |b| {
b.iter(|| {
assert_eq!(
array_replace_all(
list_array.clone(),
from_array.clone(),
to_array.clone()
),
*black_box(&expected_array)
)
black_box(array_replace_all(
list_array.clone(),
from_array.clone(),
to_array.clone(),
))
})
});
}
Expand Down
Loading