fix: respect Parquet column order when pruning#22118
Open
kumarUjjawal wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
documentation
alamb
reviewed
May 12, 2026
| } | ||
| } | ||
|
|
||
| #[test] |
Contributor
There was a problem hiding this comment.
is there some way to reduce the boiler plate in these tests? Also are we sure they are all necessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Parquet min/max statistics are only safe to use when DataFusion knows the order used to write them. If DataFusion uses stats with the wrong order, it can skip data that should be read and return wrong results.
What changes are included in this PR?
This PR checks Parquet column order before using min/max statistics for file, row group, and page pruning.
It also skips unsafe deprecated min/max statistics for columns whose natural order is not signed.
For files without column order metadata, DataFusion now uses a conservative fallback. It only uses min/max pruning for signed-order columns.
Are these changes tested?
Yes
Are there any user-facing changes?
Yes.
Queries over older or external Parquet files without column order metadata may scan more data for unsigned integers, strings, binary values, and booleans. This is intentional to avoid wrong results.