Only parse FROM identifier in CTE if using Hive#2241
Open
Viicos wants to merge 1 commit intoapache:mainfrom
Open
Only parse FROM identifier in CTE if using Hive#2241Viicos wants to merge 1 commit intoapache:mainfrom
Viicos wants to merge 1 commit intoapache:mainfrom
Conversation
iffyio
reviewed
Mar 2, 2026
| } | ||
| }; | ||
| if self.parse_keyword(Keyword::FROM) { | ||
| if dialect_of!(self is HiveDialect) && self.parse_keyword(Keyword::FROM) { |
Contributor
There was a problem hiding this comment.
not sure I follow the intent of the PR, is it rather that hive should support supports_from_first_select (i.e. what's the difference in behavior from hive vs other dialects)?
Author
There was a problem hiding this comment.
I gave more context in the issue I created; I'm not knowledgeable enough about Hive to understand if it should support FROM first selects, and it is unclear (see also #235 (comment)) why this FROM token parsing was introduced here. Maybe the intent was indeed to support FROM first selects, but I'd rather not break things here so that's why I only gated this FROM parsing for Hive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2236.