chore: refactor cast module numeric data types#3623
Merged
parthchandra merged 4 commits intoapache:mainfrom Mar 3, 2026
Merged
chore: refactor cast module numeric data types#3623parthchandra merged 4 commits intoapache:mainfrom
parthchandra merged 4 commits intoapache:mainfrom
Conversation
Contributor
Author
|
fixing merge conflicts |
coderfender
force-pushed
the
refactor_cast_module_numeric
branch
2 times, most recently
from
f95475f to
70953f8
Compare
coderfender
force-pushed
the
refactor_cast_module_numeric
branch
from
70953f8 to
96b6b55
Compare
Contributor
Author
|
@andygrove , @parthchandra This is the next part of the cast module refactor moving all (from) numeric based casts into a new file. Please take a look whenever you get a chance |
andygrove
approved these changes
Mar 3, 2026
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
LGTM pending CI. Thanks @coderfender
Contributor
Author
|
@andygrove , seems like there are some transient failures barring which CI looks good. Please rerun whenever you get a chance |
Contributor
Author
|
@andygrove thank you for kicking off the CI . The tests pass now. Please merge this whenever you get a chance I will rebase #3624 and mark it ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3459 .
Rationale for this change
cast.rstonumeric.rsto improve code organization.is_df_cast_from_int_spark_compatible , is_df_cast_from_float_spark_compatible ,is_df_cast_from_decimal_spark_compatibleto port out DF supported casts tonumeric.rsWhat changes are included in this PR?
All numeric casts (casts from numeric int / decimal to other data types) are moved to a new file called
numeric.rs.How are these changes tested?