feat: add support for aes_decrypt expression#3497
feat: add support for aes_decrypt expression#3497rafafrdz wants to merge 18 commits intoapache:mainfrom
aes_decrypt expression#3497Conversation
3b7cc7f to
eb318d1
Compare
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
Outdated
Show resolved
Hide resolved
…s_decrypt # Conflicts: # native/spark-expr/src/comet_scalar_funcs.rs
|
Thanks for the contribution @rafafrdz. I took a quick look and this looks nice. I kicked off CI. On the testing side, the current tests only cover GCM mode with a 256-bit key. Since the Rust implementation also supports CBC and ECB modes with PKCS padding, and handles 128-bit, 192-bit, and 256-bit keys, it would be great to add test coverage for those combinations. It might also be worth adding a null input test, maybe inserting a row with null encrypted data and verifying the result is null. |
…to feat/add-support-aes_decrypt
Done 😄 @andygrove |
Summary
aes_decryptby mapping AesDecrypt to native scalar functionaes_decrypt.Closes [Feature] Support Spark expression: aes_decrypt #3188