Fix nic adapater and root disk controller for UEFI VMs#13108
Draft
harikrishna-patnala wants to merge 1 commit intoapache:4.20from
Draft
Fix nic adapater and root disk controller for UEFI VMs#13108harikrishna-patnala wants to merge 1 commit intoapache:4.20from
harikrishna-patnala wants to merge 1 commit intoapache:4.20from
Conversation
Member
Author
|
@blueorangutan package |
|
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13108 +/- ##
============================================
+ Coverage 16.25% 16.26% +0.01%
- Complexity 13420 13440 +20
============================================
Files 5662 5665 +3
Lines 500161 500559 +398
Branches 60730 60791 +61
============================================
+ Hits 81300 81440 +140
- Misses 409777 410011 +234
- Partials 9084 9108 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if (params != null && params.get(VmDetailConstants.NIC_ADAPTER) != null && !params.get(VmDetailConstants.NIC_ADAPTER).isEmpty()) { | ||
| nicAdapter = params.get(VmDetailConstants.NIC_ADAPTER); | ||
| } else if (MapUtils.isNotEmpty(params) && params.containsKey(GuestDef.BootType.UEFI.toString())) { | ||
| nicAdapter = "e1000"; |
Member
There was a problem hiding this comment.
any reason of this change ?
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17735 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes the issue #11212
Issue: UEFI-based VMs on KVM were unable to attach more than a few additional disks or NICs because the default disk bus selection caused higher PCI device usage, leading to PCI slot exhaustion.
Fix: Updated the guest disk bus selection logic to use SCSI for Linux-based UEFI guests instead of VIRTIO, which reduces PCI device usage and improves support for attaching additional volumes and network interfaces. Existing Windows and non-UEFI behavior remains unchanged.
Fixed NIC attachment issues for UEFI VMs by defaulting the NIC adapter to e1000 when UEFI is enabled and no NIC adapter is explicitly specified.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?