GHA: Fix permissions for merge-conflict-checker#12830
Closed
vishesh92 wants to merge 1 commit intoapache:4.20from
Closed
GHA: Fix permissions for merge-conflict-checker#12830vishesh92 wants to merge 1 commit intoapache:4.20from
vishesh92 wants to merge 1 commit intoapache:4.20from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions workflow for the merge conflict checker to address permission-related failures when interacting with pull requests.
Changes:
- Grants
pull-requests: writepermission at the workflow level inmerge-conflict-checker.yml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| permissions: # added using https://github.com/step-security/secure-workflows | ||
| contents: read | ||
| pull-requests: write |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12830 +/- ##
=========================================
Coverage 16.24% 16.25%
- Complexity 13411 13413 +2
=========================================
Files 5664 5664
Lines 500463 500463
Branches 60779 60779
=========================================
+ Hits 81308 81334 +26
+ Misses 410059 410035 -24
+ Partials 9096 9094 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the failure of merge-conflict-checker.yml by making a small change to the workflow permissions in
.github/workflows/merge-conflict-checker.yml, granting the workflow write access to pull requests.Some failing runs:
https://github.com/apache/cloudstack/actions/runs/23049303719
https://github.com/apache/cloudstack/actions/runs/23143958894
https://github.com/apache/cloudstack/actions/runs/23147814894
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?