Open
Conversation
Member
Author
|
@blueorangutan package |
|
@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17163 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12819 +/- ##
============================================
- Coverage 17.95% 17.94% -0.01%
- Complexity 16259 16264 +5
============================================
Files 5954 5959 +5
Lines 534838 535094 +256
Branches 65423 65440 +17
============================================
+ Hits 96010 96043 +33
- Misses 428053 428273 +220
- Partials 10775 10778 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
updateVmNicAPI, allowing users to enable or disable their VMs network interface cards (NICs).Currently, this API supports only KVM with the following parameters:
nicidstateEnabledorDisabledFuture updates will extend this API to support additional NIC properties and hypervisors.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
All tests were performed using only one NIC in the VM. Furthermore, the results of all tests were obtained using the
ip acommand executed inside the VM.EnabledtoDisabledDisabledtoEnabledEnabledstateDisabledstateHow did you try to break this feature and the system with this change?