Camel-Qdrant: collect processors to be used as ref beans#21705
Camel-Qdrant: collect processors to be used as ref beans#21705smongiar wants to merge 1 commit intoapache:mainfrom
Conversation
d203cef to
cd5c037
Compare
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
There are uncommitted changes |
cd5c037 to
b3b959b
Compare
apupier
left a comment
There was a problem hiding this comment.
I do not understand the link between the commit message and all the modifications.
the different modifications that would worth different commits/PR) that I understood are:
- In the component, a parameter has been added for max results
- some changes in jbang to look to src/main/resources for application.properties
- specific Qdrant Processors
| Collections.Distance distanceEnum = switch (distance.toLowerCase()) { | ||
| case "cosine" -> Collections.Distance.Cosine; | ||
| case "euclid" -> Collections.Distance.Euclid; | ||
| case "dot" -> Collections.Distance.Dot; | ||
| case "manhattan" -> Collections.Distance.Manhattan; | ||
| default -> throw new IllegalArgumentException( | ||
| "Unknown distance metric: " + distance + ". Supported values: Cosine, Euclid, Dot, Manhattan"); | ||
| }; |
There was a problem hiding this comment.
What about using RAGCreateCollection.valueOf()?
It would allow to work with new unit of distance if added later in the library
There was a problem hiding this comment.
that's a good point. I wrongly assumed it's immutable. Let me try this. Thank you.
|
There are uncommitted changes |
b3b959b to
c335258
Compare
c335258 to
eeed803
Compare
davsclaus
left a comment
There was a problem hiding this comment.
you have some commits for camel-jbang, this should not be included here when its about qdrant
Sure not mentioned in commit message, but useful to limit results during a vectorial search. I implemented an example that make use of it
Exactly. It was not mentioned in commit message, but it's in the PR description. Basically I tried to export a Qdrant example app with SB and Quarkus. Something like:
I faced some issues, so I need to enforce application.properties check to avoid maven fallback
That's mentioned in commit message |
|
please separate this and create a new JIRA about camel-jbang |
eeed803 to
f391a04
Compare
Description
Need to collect processors and beans for more comfortable usage in route DSL definitions. Some changes involve JBang as well to make it work with camel CLI
Target
[ X] I checked that the commit is targeting the correct branch (Camel 4 uses the
mainbranch)[ X] I have run
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.