Camel 22510 avoid leaking internal data types#21704
Camel 22510 avoid leaking internal data types#21704chandru9 wants to merge 4 commits intoapache:mainfrom
Conversation
# Conflicts: # components/camel-ai/camel-langchain4j-agent/src/main/java/org/apache/camel/component/langchain4j/agent/LangChain4jAgentProducer.java
|
please rebase this branch |
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
use junit6 instead of 5 |
|
Do we expect users will want to convert from |
No we dont use that anywhere else. And indeed its not a type anyone really use. Also this PR has an unit that doesn't really test the newly introduced converter |
|
@chandru9 can you eplain your reason for this PR |
|
@jamesnetherton : Good point. The BufferedImage converter was added to support direct image processing inputs, but since Camel routes typically handle images as byte[], InputStream, or WrappedFile, and we already detect the MIME type to create the appropriate ImageContent, introducing BufferedImage may not be necessary. To avoid introducing the AWT dependency, I can remove the BufferedImage converter and rely on byte[] / InputStream based conversion using the detected content-type. This should cover the intended use cases for image processing in routes. |
|
@davsclaus : PR intended to improve the usability of the langchain4j-agent component by enabling automatic body conversion to AiAgentBody for common input types such as files, streams,text.image etc. |
|
Thanks, removing that AWT BufferedImage is welcome. |
Description
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.